Skip to content

add CBP get users by group #295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

add CBP get users by group #295

wants to merge 1 commit into from

Conversation

paoloromolini
Copy link
Contributor

PR reopened in place of #291
following @JinHuangAtZen comments.

@paoloromolini
add CBP get users by group
de64965 
Signed-off-by: Paolo Romolini <[email protected]>
JinHuangMelb
JinHuangMelb reviewed Nov 9, 2023
View reviewed changes
Copy link

@JinHuangMelb JinHuangMelb left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @paoloromolini, I think there is one step missing, which is generate the mock client as mentioned in the readme https://github.com/nukosuke/go-zendesk#to-regenerate-the-mock-client.
After running the go generate ./..., you will see the updated client.go file with the newly added functions. That's why the test fail.

@paoloromolini
Copy link
Contributor Author

Hi @JinHuangAtZen I got this error when running the command:

go generate ./...                                                                                                                                                                                           [9:14:40]
2023/11/09 09:16:33 Loading input failed: api.go:8:2: unknown embedded interface AppAPI
zendesk/api.go:4: running "mockgen": exit status 1

@JinHuangMelb
Copy link

Hi @JinHuangAtZen I got this error when running the command:

go generate ./...                                                                                                                                                                                           [9:14:40]
2023/11/09 09:16:33 Loading input failed: api.go:8:2: unknown embedded interface AppAPI
zendesk/api.go:4: running "mockgen": exit status 1

Hi @paoloromolini , I've made a new PR with all your changes here #296 and it's passing the tests. I think the issue you see is because this library was recently upgraded to use https://github.com/uber-go/mock, it might not installed in your local dev environment.

@dolmen dolmen mentioned this pull request Dec 5, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@JinHuangMelb JinHuangMelb JinHuangMelb left review comments

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@paoloromolini @JinHuangMelb